Pluggable StreamId to GrainId mapper #6682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
reviewed
Aug 12, 2020
| @@ -121,6 +121,11 @@ public static class WellKnownGrainTypeProperties | |||
| /// </summary> | |||
| public const string StreamBindingIncludeNamespaceKey = "include-namespace"; | |||
|
|
|||
| /// <summary> | |||
| /// Key type of the grain, if it implement a legacy interface. Valid values are nameof(String), nameof(Int32) and nameof(Guid) | |||
ReubenBond
reviewed
Aug 12, 2020
| /// <summary> | ||
| /// Get the corresponding GrainId from the StreamId | ||
| /// </summary> | ||
| GrainId GetGrainId(GrainBindings grainBindings, StreamId streamId); |
There was a problem hiding this comment.
I think ultimately a model which is compositional would be advantageous. Eg, TryGetGrainId, so you can run them in sequence before falling back to a default
ReubenBond
reviewed
Aug 13, 2020
| } | ||
| var streamIdMapper = _serviceProvider.GetServiceByName<IStreamIdMapper>(string.IsNullOrWhiteSpace(mapperName) ? DefaultStreamIdMapper.Name : mapperName); |
There was a problem hiding this comment.
I think we should pass the default name through the grain bindings, rather than pass null/empty and map it here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.