Close connections asynchronously and improve gracefulness #6762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
reviewed
Oct 20, 2020
| { | ||
| this.Context.Transport.Output.CancelPendingFlush(); | ||
| outgoingCompleted = true; | ||
| } |
There was a problem hiding this comment.
I think the result here is that it ends up not gracefully draining the connection before shutdown
ReubenBond
force-pushed
the
dev/jmorman/ConnectionDisposed
branch
from
c4fa6b3
to
0d2b21a
Compare
|
I pushed an update on top of your commit, @JohnMorman, and closed the PR I had open (#6877) |
ReubenBond
changed the title
ReubenBond
force-pushed
the
dev/jmorman/ConnectionDisposed
branch
from
0d2b21a
to
e4f9207
Compare
|
@benjaminpetit since I made large changes here, could you please take a look, too? |
…elPendingFlush()/.CancelPendingRead() on the same pipe which results in an ObjectDisposedException
ReubenBond
force-pushed
the
dev/jmorman/ConnectionDisposed
branch
from
e4f9207
to
545e73e
Compare
shmurchi
pushed a commit
to shmurchi/orleans
that referenced
this pull request
Mar 2, 2021
* Lock around connection cleanup so we don't call .Complete() and .CancelPendingFlush()/.CancelPendingRead() on the same pipe which results in an ObjectDisposedException * Close connections asynchronously and improve gracefulness Co-authored-by: ReubenBond <rebond@microsoft.com>
ReubenBond
added a commit
that referenced
this pull request
Mar 3, 2021
* Close connections asynchronously and improve gracefulness (#6762) * Lock around connection cleanup so we don't call .Complete() and .CancelPendingFlush()/.CancelPendingRead() on the same pipe which results in an ObjectDisposedException * Close connections asynchronously and improve gracefulness Co-authored-by: ReubenBond <rebond@microsoft.com> * Adding await for GatewayListNotification * Updating GatewayManager interfaces Co-authored-by: John Morman <jmorman@microsoft.com> Co-authored-by: ReubenBond <rebond@microsoft.com>
This was referenced Apr 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock around connection cleanup so we don't call .Complete() and .CancelPendingFlush()/.CancelPendingRead() on the same pipe which results in an ObjectDisposedException.Fixes #6747
EDIT by @ReubenBond:
Updated PR description
Connection.CloseAsync(Exception)method, which closes the connection asynchronously, completing the returned task once it has