2359 upgrade chirper to 3.3 #6770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for upgrading this sample! It seems that you updated to Orleans 3.3, not 3.1 though (which is better actually). Could you move the source files to the 3.3 subfolder? |
|
Sure will move source files. |
Signed-off-by: Kashif Soofi <kashif.soofi+git@gmail.com>
|
Many thanks, @kashifsoofi! |
benjaminpetit
pushed a commit
to benjaminpetit/orleans
that referenced
this pull request
Dec 10, 2020
* 2359 Upgrade Chirper to dotnet core 3.1 * 2359 Added missing reference * 2359 Moved Chirper to 3.3 folder Signed-off-by: Kashif Soofi <kashif.soofi+git@gmail.com> Co-authored-by: Kashif Soofi <kashif.soofi@tandem.co.uk>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated Chirper to dotnet core 3.1 #2359