Fix race in shutdown WorkItemGroups #6785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminpetit
pushed a commit
to benjaminpetit/orleans
that referenced
this pull request
Dec 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a minute chance of hitting a race in
WorkItemGroupwhen a task is enqueued between the time the dequeue lock inEnqueueis exited and the time thefinallylock is entered, if theWorkItemGroupis in a shutdown state.Found by inspection. I'm not sure that this has ever been hit, it's a very minor case.
The bug was introduced when I changed
WorkItemGroupfrom denying execution after shutdown to allowing it (with a warning/error log).