Try to limit forwarding when a grain activation throws an exception in OnActivateAsync() #6891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
reviewed
Jan 13, 2021
| /// <summary> | ||
| /// Remove all expired value from the LRU instance. | ||
| /// </summary> | ||
| public void RemoveExpired() |
There was a problem hiding this comment.
Is this only called from test code?
There was a problem hiding this comment.
No, I forgot a commit :) I just call it when we delete idle activations
|
Looks like there are some tests which need fixing (wrong exception type), which is a good sign :) |
…tion during activation collection
|
/azp run Azure DevOps - Functional |
|
Azure Pipelines successfully started running 1 pipeline(s). |
benjaminpetit
added a commit
to benjaminpetit/orleans
that referenced
this pull request
Jan 15, 2021
…n OnActivateAsync() (dotnet#6891)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to reduce the occurrence of forwarding failure because a grain cannot be activated due to a failure in
OnActivateAsync().When a grain has no activation, it's possible that multiple silos will try to create multiple activations for the same grain identity at the same time. But only one activation will win the race, and all other silos will then forward the requests to the winning activation.
If this winning activation throws during
OnActivateAsync(), it might trigger another potential race for activation creation, and additional forwarding. As a result, the user might see several "Forwarding failed" exceptions instead of the exception that was thrown during the activation process.