Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project and package dependencies cleanup #6956

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Conversation

pentp
Copy link
Contributor

@pentp pentp commented Feb 15, 2021

  • Multi-target Orleans.Core.Abstractions and Orleans.Runtime.Abstractions so that they don't pull in netstandard2.0 legacy packages for .NET Core targets.
  • Remove a lot of unnecessary dependencies.
  • Downgrade some netstandard2.0-only packages that were causing conflicts with inbox packages for .NET Core 3.1 targets.
  • Fix a couple of build errors surfaced by multi-targeting .net5.0 in abstractions projects and enable strict C# feature to guard against similar issues affecting netstandard2.0 projects.
  • Use embedded PDBs for .NET Core targets.
  • Enable Server GC for tests on .NET Core.

@veikkoeeva
Copy link
Contributor

I note here that if the problems of refactoring or small enough, should work on improving ADO.NET packages. Also, one thing to consider is if the #ifdefs should remain or be removed (which creates one common dll shared by the packages users install from Nuget). :P

Use embedded PDBs for .NET Core targets.
@ReubenBond ReubenBond merged commit 0d44584 into dotnet:master Feb 17, 2021
@pentp pentp deleted the deps-cleanup branch February 17, 2021 16:54
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants