Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul samples #7114

Merged
merged 26 commits into from
Jun 17, 2021
Merged

Overhaul samples #7114

merged 26 commits into from
Jun 17, 2021

Conversation

ReubenBond
Copy link
Member

This PR overhauls the samples in the following ways:

  • All samples updated to Orleans 3.4.x
  • Sample folder structure flattened - no more 1.x, 2.0, 2.1, 2.3, 3.0, 3.1, 3.3 folders
  • All samples have a README.md, usually with images (screenshots, diagrams, etc)
  • Top-level README.md which indexes all of the samples and describes what each one demonstrates
  • Samples use .NET Generic Host with .UseOrleans instead of SiloHostBuilder
  • Many samples simplified
  • Added a Kubernetes sample (named Voting)

Several samples were removed:

  • AdHocReactiveCaching - ideally, we could move this to a separate repository and link it from the top-level README in an Advanced Samples
  • HelloWorldCpp - this C++ sample involves manually hosting CoreCLR and is too advanced for an in-repo sample. It could also be an advanced sample in an external repository

I believe we should also migrate the OneBoxDeployment sample into an external repository with a link from the top-level README. cc @veikkoeeva. I have left it where it is for now.

@benjaminpetit benjaminpetit merged commit a0a0bb2 into dotnet:main Jun 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants