Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selector for the client #7144

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Add selector for the client #7144

merged 1 commit into from
Aug 13, 2021

Conversation

andyatwork
Copy link
Contributor

Adds the ability to use a certificate selector for client connections. See issue #7143 .

@dnfadmin
Copy link

dnfadmin commented Jul 7, 2021

CLA assistant check
All CLA requirements met.

@ReubenBond ReubenBond self-assigned this Jul 12, 2021
@ReubenBond
Copy link
Member

ReubenBond commented Aug 5, 2021

@andyatwork is this ready for review? It's currently marked as a Draft. It looks good to me

@ReubenBond ReubenBond added the Needs: backport PRs which should be backported to a (prior) release branch label Aug 5, 2021
@andyatwork andyatwork marked this pull request as ready for review August 5, 2021 15:53
@ReubenBond ReubenBond merged commit edb1322 into dotnet:main Aug 13, 2021
@ReubenBond
Copy link
Member

Thanks, @andyatwork. I figure we can merge now and add additional tests later if you have time. I'll backport it to the 3.5.0 branch so that we can include it in the next release.

ReubenBond pushed a commit to ReubenBond/orleans that referenced this pull request Aug 13, 2021
ReubenBond added a commit to ReubenBond/orleans that referenced this pull request Aug 13, 2021
benjaminpetit pushed a commit that referenced this pull request Aug 16, 2021
* Add selector for the client (#7144)

* Add selector for the client (#7144)

Co-authored-by: Andy Petralli <andres.petralli@microsoft.com>
@andyatwork andyatwork deleted the dev/andyatwork/tlsselector branch September 2, 2021 20:28
@andyatwork
Copy link
Contributor Author

Thanks for the merge and backport! Much appreciated!

benjaminpetit pushed a commit to benjaminpetit/orleans that referenced this pull request Sep 22, 2021
* Add selector for the client (dotnet#7144)

* Add selector for the client (dotnet#7144)

Co-authored-by: Andy Petralli <andres.petralli@microsoft.com>
ReubenBond added a commit that referenced this pull request Sep 22, 2021
* Add selector for the client (#7144)

* Add selector for the client (#7144)

Co-authored-by: Andy Petralli <andres.petralli@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs: backport PRs which should be backported to a (prior) release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants