Updated AzureBlobStorage to use state type during JSON deserialization #7147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thank you @benthepoet! |
ReubenBond
approved these changes
Jul 7, 2021
|
@ReubenBond Apologies for the ping... Are there any plans to release this change? |
ReubenBond
pushed a commit
to ReubenBond/orleans
that referenced
this pull request
Aug 24, 2021
|
Please feel free to ping any time. I've opened #7212 to backport this to the 3.5.0 branch, which we will hopefully be able to release this week, all going well |
benjaminpetit
pushed a commit
to benjaminpetit/orleans
that referenced
this pull request
Sep 22, 2021
…n. (dotnet#7147) (dotnet#7212) Co-authored-by: Ben Hanna <benpaulhanna@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
AzureBlobStoragepersistence provider doesn't use the state type when deserializing JSON. As a result, this makes it so that the provider requiresTypeNameHandling.Allin order to work.The other providers all use the state type during JSON deserialization, which allows you to use
TypeNameHandling.None.