Fix unhandled exception on k8s watcher background task #7168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unawaited background task to suppress any exception from the ChannelReader's Completion task.
The channel reader's Completion task would re-raise the exception set on the channel writer and cause an unhandled exception in the unawaited task and crash silo.
We have witnessed multiple cases when the HTTPS connection between the k8s watcher and the k8s API was lost, and it caused a silo crash. The investigation led to this unawaited background task. (See attached exception.)