Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record result of deserialization for keyed serializers #7336

Merged

Conversation

ReubenBond
Copy link
Member

@ReubenBond ReubenBond commented Oct 11, 2021

Fixes #7182

Thank you for debugging this and creating a test case, @kiwidev!

Microsoft Reviewers: Open in CodeFlow

@ReubenBond ReubenBond added this to the 3.5.1 milestone Oct 11, 2021
@kiwidev
Copy link

kiwidev commented Oct 12, 2021

Thanks for sorting it! Sorry, we stopped using the code path so I didn't get to sending you a PR.

@benjaminpetit benjaminpetit merged commit 100e81a into dotnet:3.x Oct 13, 2021
@ReubenBond ReubenBond deleted the fix/fallbackserializer-record-result branch October 14, 2021 18:26
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ILBasedExceptionSerializer fails to deserialize referenced ISerializable objects
3 participants