Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade 'GPS Tracker' sample #8130

Merged
merged 1 commit into from Nov 18, 2022
Merged

Upgrade 'GPS Tracker' sample #8130

merged 1 commit into from Nov 18, 2022

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Nov 11, 2022 •
edited by ghost

Relates to #8035

Microsoft Reviewers: Open in CodeFlow

@IEvangelist IEvangelist mentioned this pull request Nov 11, 2022
Closed
17 tasks
ReubenBond
ReubenBond approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@ReubenBond ReubenBond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be using the console lifetime instead of binding to the Console.CancelKeyPress event

@ReubenBond ReubenBond merged commit 32bae99 into dotnet:main Nov 18, 2022
@ReubenBond
Copy link
Member

Opened #8167 for the comment I left here

@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ReubenBond ReubenBond ReubenBond approved these changes

@benjaminpetit benjaminpetit Awaiting requested review from benjaminpetit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IEvangelist @ReubenBond