Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default parameter values for AddJsonSerializer #8228

Merged
merged 1 commit into from Dec 16, 2022

Conversation

ReubenBond
Copy link
Member

@ReubenBond ReubenBond commented Dec 15, 2022

I've seen a case where a developer was calling UseJsonSerializer() with no parameters, resulting in the JSON serializer not being used for anything.

This PR tries to make it more obvious that the delegates used to opt-in to using the serializer are important by removing the defaults.

Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, :shipit: when you're ready.

@ReubenBond ReubenBond merged commit d423f2a into dotnet:main Dec 16, 2022
@ReubenBond ReubenBond deleted the fix/json-config-methods branch December 16, 2022 00:45
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants