Add Redis storage tests based on CommonStorageTests #8265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, @willg1983! I will rebase your PR on top of #8261 and force-push it. When we're ready (and #8261 is in), we will squash commit it. |
ReubenBond
changed the title
ReubenBond
force-pushed
the
Add_Redis_CommonStorageTests
branch
from
0e696c9
to
b2df281
Compare
|
Rebased & fixed |
ReubenBond
approved these changes
Jan 19, 2023
ReubenBond
force-pushed
the
Add_Redis_CommonStorageTests
branch
2 times, most recently
from
e6ac6c4
to
7ba6c74
Compare
ReubenBond
force-pushed
the
Add_Redis_CommonStorageTests
branch
from
42e1dc2
to
68857b4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds additional functional tests based on
CommonStorageTestsfor theRedisGrainStorageprovider.@ReubenBond These tests will currently fail as I have not fixed the issues they highlight in the
RedisGrainStorage, as I know there are changes to that in PR #8261 and I wanted to avoid conflicts - we will need to rebase one of these PRs onto the other I presume?Microsoft Reviewers: Open in CodeFlow