Make PooledArrayBufferWriter more versatile, rename
#8453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PooledArrayBufferWriter
5 tasks
pentp
reviewed
Jun 6, 2023
|
|
||
| public void Deserialize<TInput>(ref Reader<TInput> reader, scoped ref PooledBuffer value) | ||
| { | ||
| const int MaxSpanLength = 4096; |
There was a problem hiding this comment.
Why such a small buffer size? Wouldn't something like 1MB (or even bigger) be more appropriate? There's no reason to prefer small buffers when they are pooled.
There was a problem hiding this comment.
Each buffer is owned by at most one instance at a time, so if the buffers are individually large and there are many instances, then the memory footprint of the application may become unnecessarily large. Ideally, this should be changed to have adaptive buffer sizes (eg powers of 2 from 256b to 1MB), maybe with an initial size hint (defaulting to 4k, perhaps)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports slicing, for example
Microsoft Reviewers: Open in CodeFlow