Improve DeploymentLoadPublisher logic and cleanup #8472
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UpdateRuntimeStatistics
is a notification method and since we use it withTask.WhenAll
, waiting for its completion before continuing can result in one (eg, dead) silo delaying others from receiving updates: a slow silo will prevent the next round of updates from being collected and sent. Additionally, we do not care if this method fails, so we do not need to track its completion. Therefore, I have marked the method[OneWay]
.DateTime.UtcNow
, so we are susceptible to clock changes. Setting the clock on a host backwards can prevent other hosts from applying updates for some period of time. Therefore, I changed the logic to use a monotonic clock which always proceeds on every cycle, even if the clock has been set backwards.async
-await
overContinueWith
) changes, plus a more invasive refactoring to rename members to fit the modern C# style.Microsoft Reviewers: Open in CodeFlow