Small, targeted refactor: Address CA1517 (use nameof) #8516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ReubenBond , @abe545 , @benjaminpetit , and others - I'm a former MSFTie of almost 15 years, just thought I would help do a little refactoring here and there if that's OK. Trying to keep PRs small, targeted, and useful. |
ReubenBond
approved these changes
Jul 5, 2023
|
Thank you @cybertyche! Thanks for reviewing @mitchdenny. Feel free to merge PRs which LGTY |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is limited to a single refactor repeated over many times: addressing all instances of CA1517 (use nameof() instead of string constants).
Leaving this PR to only that one refactoring so as to make review substantially simpler.
Microsoft Reviewers: Open in CodeFlow