Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes nullability of returned IGrainReminder in GrainReminderExtensions #8544

Merged
merged 1 commit into from Aug 16, 2023
Merged

Fixes nullability of returned IGrainReminder in GrainReminderExtensions #8544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Orleans.Reminders/GrainReminderExtensions.cs
View file
Open in desktop
Expand Up @@ -80,17 +80,17 @@ private static Task UnregisterReminder(IGrainContext? grainContext, IGrainRemind
/// <param name="grain">The grain instance.</param>
/// <param name="reminderName">Reminder to return</param>
/// <returns>Promise for Reminder handle.</returns>
public static Task<IGrainReminder> GetReminder(this Grain grain, string reminderName) => GetReminder(grain?.GrainContext, reminderName);
public static Task<IGrainReminder?> GetReminder(this Grain grain, string reminderName) => GetReminder(grain?.GrainContext, reminderName);

/// <summary>
/// Returns a previously registered reminder.
/// </summary>
/// <param name="grain">A grain.</param>
/// <param name="reminderName">Reminder to return</param>
/// <returns>Promise for Reminder handle.</returns>
public static Task<IGrainReminder> GetReminder(this IGrainBase grain, string reminderName) => GetReminder(grain?.GrainContext, reminderName);
public static Task<IGrainReminder?> GetReminder(this IGrainBase grain, string reminderName) => GetReminder(grain?.GrainContext, reminderName);

private static Task<IGrainReminder> GetReminder(IGrainContext? grainContext, string reminderName)
private static Task<IGrainReminder?> GetReminder(IGrainContext? grainContext, string reminderName)
{
ArgumentNullException.ThrowIfNull(grainContext, "grain");
if (string.IsNullOrWhiteSpace(reminderName)) throw new ArgumentNullException(nameof(reminderName));
Expand Down