Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception while collecting activations #8740

Merged
merged 1 commit into from Nov 29, 2023
Merged

Conversation

nichvolodov
Copy link
Contributor

@nichvolodov nichvolodov commented Nov 24, 2023

  1. now1: var now = DateTime.UtcNow; at ScanStale (ActivationCollector line 214)
  2. now2: DateTime.UtcNow at MakeTicketFromTimeSpan (ActivationCollector line 364)

if now2 > now1 and activation.KeepAliveUntil == DateTime.MaxValue - we have exception (System.ArgumentOutOfRangeException: The added or subtracted value results in an un-representable DateTime. (Parameter 't'))

Microsoft Reviewers: Open in CodeFlow

@ReubenBond ReubenBond merged commit 01366de into dotnet:main Nov 29, 2023
19 checks passed
@ReubenBond
Copy link
Member

Great find, thank you!

ReubenBond pushed a commit to ReubenBond/orleans that referenced this pull request Dec 2, 2023
…ntil = DateTime.MaxValue (dotnet#8740)

Co-authored-by: boris.nichvolodov <boris.nichvolodov@my.games>
ReubenBond added a commit that referenced this pull request Dec 2, 2023
…ntil = DateTime.MaxValue (#8740) (#8755)

Co-authored-by: nichvolodov <nichvolodov.boris@gmail.com>
Co-authored-by: boris.nichvolodov <boris.nichvolodov@my.games>
ReubenBond added a commit that referenced this pull request Dec 2, 2023
…ntil = DateTime.MaxValue (#8740) (#8755)

Co-authored-by: nichvolodov <nichvolodov.boris@gmail.com>
Co-authored-by: boris.nichvolodov <boris.nichvolodov@my.games>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants