New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft.Extensions.Configuration support #8764
Merged
benjaminpetit
merged 10 commits into
dotnet:main
from
ReubenBond:feature/iconfiguration/1
Jan 9, 2024
Merged
Microsoft.Extensions.Configuration support #8764
benjaminpetit
merged 10 commits into
dotnet:main
from
ReubenBond:feature/iconfiguration/1
Jan 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
force-pushed
the
feature/iconfiguration/1
branch
from
December 8, 2023 15:01
abdd2e1
to
168cca5
Compare
@benjaminpetit ptal |
ReubenBond
force-pushed
the
feature/iconfiguration/1
branch
from
January 8, 2024 19:16
46aae34
to
2397cab
Compare
ReubenBond
force-pushed
the
feature/iconfiguration/1
branch
from
January 9, 2024 00:27
a14481b
to
e0af124
Compare
benjaminpetit
approved these changes
Jan 9, 2024
This is pretty cool! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for configuring clients and silos using Microsoft.Extensions.Configuration, otherwise known as
IConfiguration
.The systems is extensible: providers of known kinds (Clustering, Reminders, GrainStorage, Streaming, BroadcastChannel) can be registered using an assembly-level
RegisterProvider
attribute like so:Perhaps we could make the configuration more open-ended by allowing the "kinds" themselves to be extensible. The only non-trivial part of doing that is that we need to know when a "kind" is a singleton ("Clustering", "Reminders") vs named (the others).
Here is an example configuration for a server:
Here is an example configuration for a corresponding client:
TODO
Later
Fixes #6565
Microsoft Reviewers: Open in CodeFlow