Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support implementing multiple IConverter<,> in single converter class #8881

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Support implementing multiple IConverter<,> in single converter class #8881

merged 5 commits into from
Jul 8, 2024

Commits on Jul 8, 2024

  1. Added failing ICopier unit test 

    - When declaring a single converter class for multiple surrogates,
  ICopier will always resolve the last declared IConverter<,> interface,
  failing with a InvalidCastException at runtime
    @ccorsano @ReubenBond
    ccorsano authored and ReubenBond committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ccae5e3 View commit details
    Browse the repository at this point in the history

  2. Completed failing ICopier unit test 

    - Added Equals and GetHashCode to foreign types
    @ccorsano @ReubenBond
    ccorsano authored and ReubenBond committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    a275a24 View commit details
    Browse the repository at this point in the history

  3. Support multiple IConverter<,> in surrogate converter class 

    - Only resolves IConverter<,> interface matching foreign type
    @ccorsano @ReubenBond
    ccorsano authored and ReubenBond committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    bfdce65 View commit details
    Browse the repository at this point in the history

  4. Switch to a stricter type equality check

    @ccorsano @ReubenBond
    ccorsano authored and ReubenBond committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    56878a9 View commit details
    Browse the repository at this point in the history

  5. x

    @ReubenBond
    ReubenBond committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    9de0fd6 View commit details
    Browse the repository at this point in the history