Ensure reminder table is initialized before access #8982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
added
the
Needs: backport
magole
reviewed
May 8, 2024
src/Azure/Orleans.Reminders.AzureStorage/Storage/AzureBasedReminderTable.cs
Outdated
Show resolved
Hide resolved
magole
reviewed
May 8, 2024
src/Azure/Orleans.Reminders.AzureStorage/Storage/AzureBasedReminderTable.cs
Show resolved
Hide resolved
magole
reviewed
May 8, 2024
src/Azure/Orleans.Reminders.AzureStorage/Storage/AzureBasedReminderTable.cs
Outdated
Show resolved
Hide resolved
magole
reviewed
May 8, 2024
ReubenBond
force-pushed
the
fix/reminder-service-startup-order
branch
from
61223a3
to
fd9b246
Compare
ReubenBond
added a commit
to ReubenBond/orleans
that referenced
this pull request
May 10, 2024
* Ensure reminder table is initialized before access (cherry picked from commit d54dd32)
ReubenBond
added a commit
that referenced
this pull request
May 13, 2024
* Ensure reminder table is initialized before access (cherry picked from commit d54dd32)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that the
IReminderTableimplementation might be accessed before it has been successfully initialized. This PR ensures that is not the case forLocalReminderServiceby initializing the table before starting theLocalReminderServiceand before grains are allowed to start.While doing so, I also implemented support for
CancellationTokeninIReminderTablefor startup/shutdown, obsoleting the existingInit()method and replacing it withStartAsync(CancellationToken), adding a newStopAsync(CancellationToken).Microsoft Reviewers: Open in CodeFlow