Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization of types inheriting from Dictionary<K,V> which add values in their constructor #8993

Merged
merged 1 commit into from
May 10, 2024

Conversation

ReubenBond
Copy link
Member

@ReubenBond ReubenBond commented May 10, 2024

Fixes #8989

Microsoft Reviewers: Open in CodeFlow

@ReubenBond
Copy link
Member Author

We need to get #8994 in first to fix the build by updating Npgsql

@ReubenBond ReubenBond force-pushed the fix/dictionary-base-codec-ctors branch from 8cdab36 to a529e8c Compare May 10, 2024 17:46
@ReubenBond ReubenBond merged commit f89629b into dotnet:main May 10, 2024
18 checks passed
@ReubenBond ReubenBond deleted the fix/dictionary-base-codec-ctors branch May 10, 2024 22:15
ReubenBond added a commit to ReubenBond/orleans that referenced this pull request May 10, 2024
…uctor (dotnet#8993)

(cherry picked from commit f89629b)

# Conflicts:
#	test/Orleans.Serialization.UnitTests/BuiltInCodecTests.cs
ReubenBond added a commit to ReubenBond/orleans that referenced this pull request May 10, 2024
…uctor (dotnet#8993)

(cherry picked from commit f89629b)

# Conflicts:
#	test/Orleans.Serialization.UnitTests/BuiltInCodecTests.cs
ReubenBond added a commit to ReubenBond/orleans that referenced this pull request May 10, 2024
…uctor (dotnet#8993)

(cherry picked from commit f89629b)

# Conflicts:
#	test/Orleans.Serialization.UnitTests/BuiltInCodecTests.cs
ReubenBond added a commit that referenced this pull request May 13, 2024
…uctor (#8993)

(cherry picked from commit f89629b)

# Conflicts:
#	test/Orleans.Serialization.UnitTests/BuiltInCodecTests.cs
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot serialize type inheriting from Dictionary
1 participant