Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Recorded flag not propagated between activities #9016

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix for Recorded flag not propagated between activities #9016

wants to merge 4 commits into from

Conversation

Costo
Copy link
Contributor

@Costo Costo commented May 21, 2024 •
edited by dotnet-policy-service bot

As discussed in #9011, create ActivityContext from traceparent and set isRemote: true to correctly propagate the Recorded flag.

Microsoft Reviewers: Open in CodeFlow

@ReubenBond ReubenBond self-assigned this May 22, 2024
@ReubenBond
Copy link
Member

ReubenBond commented May 22, 2024 •
edited

We need to fix the failing UnitTests.General.ActivityPropagationTests.WithParentActivity_Hierarchical test.
EDIT: closed accidentally

@ReubenBond ReubenBond closed this May 22, 2024
@ReubenBond ReubenBond reopened this May 22, 2024
@Costo
Copy link
Contributor Author

Costo commented Jun 4, 2024

I fixed the failing test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ReubenBond ReubenBond

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Costo @ReubenBond