Credscan - suppress false positive (#1367)

* Credscan - suppress false positive * Suppress credscan false positives * Change justification message Co-authored-by: Jan Jahoda <jajahoda@.microsoft.com>
dotnet · Jun 24, 2020 · 12160ff · 12160ff
1 parent 442070b
commit 12160ff
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/.config/CredScanSuppressions.json b/.config/CredScanSuppressions.json
@@ -0,0 +1,19 @@
+{
+    "tool": "Credential Scanner",
+    "suppressions": [
+     {
+       "file": [
+         "/src/benchmarks/micro/libraries/System.Net.Http/ec256.pfx",
+         "/src/benchmarks/micro/libraries/System.Net.Http/ec512.pfx",
+         "/src/benchmarks/micro/libraries/System.Net.Http/ecdsa.pfx",
+         "/src/benchmarks/micro/libraries/System.Net.Http/rsa1024.pfx",
+         "/src/benchmarks/micro/libraries/System.Net.Http/rsa2048.pfx",
+         "/src/benchmarks/micro/libraries/System.Net.Http/rsa4096.pfx",
+         "/src/benchmarks/micro/libraries/System.Net.Http/testclienteku.contoso.com.pfx",
+         "/src/benchmarks/micro/libraries/System.Net.Http/testservereku.contoso.com.pfx"
+       ],
+       "_justification": "Test certificates."
+     }
+    ]
+   }
+
diff --git a/src/benchmarks/micro/Serializers/DataGenerator.cs b/src/benchmarks/micro/Serializers/DataGenerator.cs
@@ -63,6 +63,7 @@ private static LoginViewModel CreateLoginViewModel()
             => new LoginViewModel
             {
                 Email = "name.familyname@not.com",
+                // [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Dummy credentials for perf testing.")]
                 Password = "abcdefgh123456!@",
                 RememberMe = true
             };

diff --git a/src/benchmarks/micro/libraries/System.Net.Http/Configuration.Certificates.cs b/src/benchmarks/micro/libraries/System.Net.Http/Configuration.Certificates.cs
@@ -11,6 +11,7 @@ public static class Configuration
     {
         public static class Certificates
         {
+            // [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Test certificate password.")]
             private const string CertificatePassword = "testcertificate";
 
             public static X509Certificate2 GetServerCertificate() => GetCertificate("testservereku.contoso.com.pfx");