remove overhead from setinput/setoutput

dotnet · Aug 17, 2022 · 128fcdf · 128fcdf
1 parent 3cc83b3
commit 128fcdf
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/src/benchmarks/micro/Serializers/Xml_FromStream.cs b/src/benchmarks/micro/Serializers/Xml_FromStream.cs
@@ -28,6 +28,7 @@ public class Xml_FromStream<T>
         private MemoryStream memoryStream;
         private byte[] memoryBytes;
         private XmlDictionaryReader xmlDictionaryReader;
+        const int IterationsBinaryXml = 100;
 
         [GlobalSetup(Target = nameof(XmlSerializer_))]
         public void SetupXmlSerializer()
@@ -73,18 +74,28 @@ public void SetupDataContractSerializer_BinaryXml_()
             memoryStream.Position = 0;
             dataContractSerializer = new DataContractSerializer(typeof(T));
             using (XmlDictionaryWriter writer = XmlDictionaryWriter.CreateBinaryWriter(memoryStream, null, null, ownsStream: false))
-               dataContractSerializer.WriteObject(writer, value);
+            {
+                writer.WriteStartElement("root");
+                for (int i = 0; i < IterationsBinaryXml; ++i)
+                   dataContractSerializer.WriteObject(writer, value);
+            }
 
             memoryBytes = memoryStream.ToArray();
             xmlDictionaryReader = XmlDictionaryReader.CreateBinaryReader(memoryBytes, XmlDictionaryReaderQuotas.Max);
         }
 
         [BenchmarkCategory(Categories.Libraries)]
-        [Benchmark(Description = nameof(XmlDictionaryReader))]
+        [Benchmark(Description = nameof(XmlDictionaryReader), OperationsPerInvoke = IterationsBinaryXml)]
         public T DataContractSerializer_BinaryXml_()
         {
             ((IXmlBinaryReaderInitializer)xmlDictionaryReader).SetInput(memoryBytes, 0, memoryBytes.Length, null, XmlDictionaryReaderQuotas.Max, null, null);
-            return (T)dataContractSerializer.ReadObject(xmlDictionaryReader);
+            xmlDictionaryReader.ReadStartElement("root");
+
+            T result = default;
+            for (int i = 0; i < IterationsBinaryXml; ++i)
+                result = (T)dataContractSerializer.ReadObject(xmlDictionaryReader);
+
+            return result;
         }
 
       // YAXSerializer is not included in the benchmarks because it does not allow to deserialize from stream (only from file and string)

diff --git a/src/benchmarks/micro/Serializers/Xml_ToStream.cs b/src/benchmarks/micro/Serializers/Xml_ToStream.cs
@@ -59,7 +59,6 @@ public void DataContractSerializer_()
         public void DataContractSerializer_BinaryXml_()
         {
             memoryStream.Position = 0;
-            ((IXmlBinaryWriterInitializer)xmlDictionaryWriter).SetOutput(memoryStream, null, null, ownsStream: false);
 
             dataContractSerializer.WriteObject(xmlDictionaryWriter, value);
         }