Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign LINQ benchmarks #91

Closed
adamsitnik opened this issue Jul 10, 2018 · 1 comment
Closed

Redesign LINQ benchmarks #91

adamsitnik opened this issue Jul 10, 2018 · 1 comment
Assignees
@adamsitnik

Comments

@adamsitnik
Copy link
Member

adamsitnik commented Jul 10, 2018 •
edited
Loading

This is a #90 followup

  1. ~~CoreFX benchmarks call .ToArray() everywhere, while they should just iterate over the enumeration (like the CoreCLR ones) ~~ fixed in don't use very expensive .ToArray() to measure other LINQ extenion methods performance #127
  2. Cast_ToBaseClass and Cast_SameType ignore provided size and iteration count and use hardcoded values. We don't know if this is by design or a bug. (cc @jorive)
  3. Some benchmarks use iteration some iterationCount argument names, this should be unified.
@adamsitnik adamsitnik mentioned this issue Jul 10, 2018
Merged
adamsitnik added a commit to adamsitnik/performance that referenced this issue Aug 28, 2018
@adamsitnik
don't use very expensive .ToArray() to measure other LINQ extenion me…
00f5067 
…thods performance! Use .Consume extension method from BDN instead, part of dotnet#91
@adamsitnik adamsitnik mentioned this issue Aug 28, 2018
Merged
adamsitnik added a commit that referenced this issue Aug 28, 2018
@adamsitnik
don't use very expensive .ToArray() to measure other LINQ extenion me…
37eecf1 
…thods performance (#127)

* don't use very expensive .ToArray() to measure other LINQ extenion methods performance! Use .Consume extension method from BDN instead, part of #91
@adamsitnik adamsitnik self-assigned this Jul 10, 2019
@adamsitnik adamsitnik mentioned this issue Jul 10, 2019
Merged
@adamsitnik
Copy link
Member Author

Fixed in #625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamsitnik adamsitnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adamsitnik