-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truly Dynamic Event #4274
Truly Dynamic Event #4274
Conversation
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/GC.Analysis.API.csproj
Show resolved
Hide resolved
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/GC.Analysis.API.csproj
Show resolved
Hide resolved
src/benchmarks/gc/GC.Infrastructure/Notebooks/Examples/GCAnalysisExamples.ipynb
Show resolved
Hide resolved
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure.Core/GC.Infrastructure.Core.csproj
Show resolved
Hide resolved
6cd369d
to
ec7ff57
Compare
c07614a
to
4c3e7d6
Compare
bcd4c83
to
ef37cb3
Compare
5e08c1b
to
0b722d2
Compare
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
Show resolved
Hide resolved
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just some nits here and there but we tested it out and it all works.
0b722d2
to
e06b946
Compare
e06b946
to
e46e782
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@cincuranet - could we please get this PR merged, seems like the Build Analysis failures are unrelated: ❌The pipeline is not valid. Job windows_22H2_x64_scenarios__Open: Step AzureCLI input connectedServiceNameARM references service connection .NET Performance (790c4451-dad9-4fda-af8b-10bd9ca328fa) which could not be found. The service connection does not exist, has been disabled or has not been authorized for use. For authorization details, refer to https://aka.ms/yamlauthz. Job ubuntu_2204_x64_scenarios__Open: Step AzureCLI input connectedServiceNameARM references service connection .NET Performance (790c4451-dad9-4fda-af8b-10bd9ca328fa) which could not be found. The service connection does not exist, has been disabled or has not been authorized for use. For authorization details, refer to https://aka.ms/yamlauthz. Thanks! |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Error was fixed earlier this week and this PR is approved by correct people, merging 👍. |
This PR is currently in a prototype state. (It is easier to review by commits)
This change:
And some other cleanups
The dynamic event consumption part can only work with microsoft/perfview#2051.