Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmarks for (de)serializing dictionaries in System.Text.Json #530

Merged
merged 7 commits into from
Jul 18, 2019
Merged

Add benchmarks for (de)serializing dictionaries in System.Text.Json #530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3580c18
Add micro benchmarks for (de)serializing dictionaries in S.T.Json
layomia May 30, 2019
e4e8ed5
Merge remote-tracking branch 'upstream/master' into dict
layomia May 31, 2019
e5727ad
Add serialize ToString benchmarks
layomia May 31, 2019
b0bc1b8
Remove extraneous namespace prefix
layomia Jun 3, 2019
3c50bba
Merge remote-tracking branch 'upstream/master' into dict
adamsitnik Jul 18, 2019
0f27991
reflect the API changes
adamsitnik Jul 18, 2019
5f71efa
use existing ReadJson and WriteJson generic classes instead od introd…
adamsitnik Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/benchmarks/micro/Serializers/DataGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@

using System;
using System.Collections.Generic;
using System.Collections.Immutable;
using System.Linq;
using System.Xml;
using System.Xml.Serialization;
using BenchmarkDotNet.Extensions;
using MessagePack;
using ProtoBuf;

Expand Down Expand Up @@ -34,6 +36,12 @@ internal static T Generate<T>()
return (T)(object)new SimpleStructWithProperties { Num = 1, Text = "Foo" };
if (typeof(T) == typeof(ClassImplementingIXmlSerialiable))
return (T)(object)new ClassImplementingIXmlSerialiable { StringValue = "Hello world" };
if (typeof(T) == typeof(Dictionary<string, string>))
return (T)(object)ValuesGenerator.ArrayOfUniqueValues<string>(100).ToDictionary(value => value);
if (typeof(T) == typeof(ImmutableDictionary<string, string>))
return (T)(object)ImmutableDictionary.CreateRange(ValuesGenerator.ArrayOfUniqueValues<string>(100).ToDictionary(value => value));
if (typeof(T) == typeof(ImmutableSortedDictionary<string, string>))
return (T)(object)ImmutableSortedDictionary.CreateRange(ValuesGenerator.ArrayOfUniqueValues<string>(100).ToDictionary(value => value));

throw new NotImplementedException();
}
Expand Down
5 changes: 5 additions & 0 deletions src/benchmarks/micro/corefx/System.Text.Json/Serializer/ReadJson.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
using BenchmarkDotNet.Attributes;
using MicroBenchmarks;
using MicroBenchmarks.Serializers;
using System.Collections.Generic;
using System.Collections.Immutable;
using System.IO;
using System.Threading.Tasks;

Expand All @@ -15,6 +17,9 @@ namespace System.Text.Json.Serialization.Tests
[GenericTypeArguments(typeof(IndexViewModel))]
[GenericTypeArguments(typeof(MyEventsListerViewModel))]
[GenericTypeArguments(typeof(BinaryData))]
[GenericTypeArguments(typeof(Dictionary<string, string>))]
[GenericTypeArguments(typeof(ImmutableDictionary<string, string>))]
[GenericTypeArguments(typeof(ImmutableSortedDictionary<string, string>))]
public class ReadJson<T>
{
private string _serialized;
Expand Down
5 changes: 5 additions & 0 deletions src/benchmarks/micro/corefx/System.Text.Json/Serializer/WriteJson.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
using BenchmarkDotNet.Attributes;
using MicroBenchmarks;
using MicroBenchmarks.Serializers;
using System.Collections.Generic;
using System.Collections.Immutable;
using System.IO;
using System.Threading.Tasks;

Expand All @@ -15,6 +17,9 @@ namespace System.Text.Json.Serialization.Tests
[GenericTypeArguments(typeof(IndexViewModel))]
[GenericTypeArguments(typeof(MyEventsListerViewModel))]
[GenericTypeArguments(typeof(BinaryData))]
[GenericTypeArguments(typeof(Dictionary<string, string>))]
[GenericTypeArguments(typeof(ImmutableDictionary<string, string>))]
[GenericTypeArguments(typeof(ImmutableSortedDictionary<string, string>))]
public class WriteJson<T>
{
private T _value;
Expand Down