You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 26, 2023. It is now read-only.
The CreatePipe method should output SafeFileHandles intead of SafeObjectHandles. By outputting SafeFileHandle directly it makes it easier to wrap these up in FileReader and FileWriter classes.
The text was updated successfully, but these errors were encountered:
There's a lot of Kernel32 which interop with files. Basically every first argument to a Kernel32 method which is named hFile or hDevice should be a SafeFileHandle instead.
It makes a lot of sense to change them all. @AArnott thoughts?
I had similar thoughts to the OP's, only CreateFile was the API I cared about. Help me understand the thinking in returning SafeObjectHandle? None of the .NET FileStream constructors know what to do with that, but maybe you had a different .NET API in mind to interact with SafeObjectHandles?
The
CreatePipe
method should outputSafeFileHandle
s intead ofSafeObjectHandle
s. By outputtingSafeFileHandle
directly it makes it easier to wrap these up inFileReader
andFileWriter
classes.The text was updated successfully, but these errors were encountered: