Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify CloseHandleSafeHandle with SafeFileHandle #74

Closed
AArnott opened this issue Jan 29, 2021 · 0 comments · Fixed by #100
Closed

Unify CloseHandleSafeHandle with SafeFileHandle #74

AArnott opened this issue Jan 29, 2021 · 0 comments · Fixed by #100
Assignees
@AArnott
Labels
enhancement New feature or request

Comments

@AArnott
Copy link
Member

AArnott commented Jan 29, 2021

For better interop with .NET BCL APIs, we should produce and accept instances of SafeFileHandle instead of our own CloseHandleSafeHandle generated type.

This was astutely brought up here: dotnet/pinvoke#429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reuse SafeFileHandle from BCL instead of creating CloseHandleSafeHandle microsoft/CsWin32
1 participant
@AArnott