Skip to content
This repository has been archived by the owner on Jul 26, 2023. It is now read-only.

Update User32::WinEventProc and MSCorEE::GetVersionFromProcess #397

Merged
merged 2 commits into from
Dec 23, 2019

Conversation

joerohde
Copy link
Contributor

User32: Update WinEventProc - Runtime Issue

  • Param 1 is IntPtr - Income parm should be be SafeEvent...
    MSCorEE: Update GetVersionFromProcess - Compile Issue
  • Can't cast [] to * without marking method unsafe and using a 'fixed' scope block.

- Param 1 is IntPtr - Income parm should be be SafeEvent...
MSCorEE: Update GetVersionFromProcess
- Can't cast [] to * without marking method unsafe and using a 'fixed' scope block.
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why either of these changes are needed. Can you elaborate?

src/User32/User32.cs Show resolved Hide resolved
src/MSCorEE/MSCorEE.Helpers.cs Outdated Show resolved Hide resolved
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the unnecessary change and will take the rest. Thanks.

@AArnott AArnott merged commit 9476c5c into dotnet:master Dec 23, 2019
@FDB-Fakim
Copy link

Is there a reason 9476c5c isn't included in PInvoke.User32.0.6.6.nupkg?

@AArnott
Copy link
Collaborator

AArnott commented May 23, 2020

@FDB-Fakim Yes: that release came out before this PR completed. :)

@AArnott
Copy link
Collaborator

AArnott commented May 23, 2020

I think what you mean to ask is "Is there a reason there hasn't been a release since this PR was merged?"

And the answer to that would be "not particularly." I suppose it is time to release another one. I'll prepare one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants