This repository has been archived by the owner on Jul 26, 2023. It is now read-only.
Add Kernel32.GetVolumeInformation #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AArnott
suggested changes
Jun 30, 2020
There was a problem hiding this comment.
Thank you so much for contributing. I have a few comments around conventions that we follow in this repo to please fix. What you have would be fine, but since there are so many different ways to represent p/invokes, enums, etc we have set on a few specific standards so that throughout the library people know what to expect as far as API names and options, that we'd like this PR to conform to as well.
|
Thanks, @AArnott . I think I addressed your feedback, let me know if you have further comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.