This repository has been archived by the owner on Jul 26, 2023. It is now read-only.
Target minimal API Sets version for AdvApi32 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private const string api_ms_win_core_processthreads_l1_1_1 = nameof(AdvApi32); | ||
| private const string api_ms_win_security_base_l1_2_0 = nameof(AdvApi32); | ||
| private const string api_ms_win_service_winsvc_l1_2_0 = nameof(AdvApi32); | ||
| #endif |
There was a problem hiding this comment.
Should you add this after the #endif?
#pragma warning restore SA1303 // Const field names must begin with upper-case letter
|
Looks really good. Thanks. |
|
BTW, I found some value in the fact that the Kernel32 unit test projects had a desktop and profile92 version so that both APISets and kernel32.dll methods were exercised. Should we do that here as well? |
|
I would do it as soon as we have at least one unit test. My concern here is why we don't have unit tests. Regarding windows services.
|
jmelosegui
added a commit
that referenced
this pull request
Nov 29, 2015
Target minimal API Sets version for AdvApi32
|
Fair point on the tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for #84