Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command handling can prevent File > Open > Folder... from working properly #174

Closed
vukelich opened this issue Sep 18, 2019 · 1 comment · Fixed by #175
Closed

Command handling can prevent File > Open > Folder... from working properly #174

vukelich opened this issue Sep 18, 2019 · 1 comment · Fixed by #175
Assignees
@drewnoakes
Labels
bug

Comments

@vukelich
Copy link

When the Project System Tools extension is installed, the File.OpenFolder command (File > Open > Folder...) is handled by Microsoft.VisualStudio.ProjectSystem.Tools.BuildLogging.BuildLoggingToolWindow.InnerExec instead of going to Microsoft.VisualStudio.Workspace.VSIntegration.SourceExplorerPackage.Exec. This happens when focus is on the "Build Logging" tool window. To fix this, BuildLoggingToolWindow needs its command handling methods (InnerQueryStatus and InnerExec) to check the value of commandGroupGuid in addition to commandId.

Repro steps:

  1. Install Project System Tools version 1.0.1.1927902 to Visual Studio 2019.
  2. Launch Visual Studio 2019.
  3. Continue to IDE without selecting any project, solution, or folder from the Get To Code dialog.
  4. Set IDE focus on the "Build Logging" tool window.
  5. Use File > Open > Folder...

Expected (notice focus is in the Solution Explorer tool window)
image

Actual (notice focus is in the Build Logging tool window)
image
@drewnoakes drewnoakes self-assigned this Sep 18, 2019
@drewnoakes drewnoakes added the bug label Sep 18, 2019
drewnoakes added a commit to drewnoakes/project-system-tools that referenced this issue Sep 18, 2019
@drewnoakes
Validate query has required GUID
7b31bda 
Fixes dotnet#174
@drewnoakes drewnoakes mentioned this issue Sep 18, 2019
Merged
@drewnoakes
Copy link
Member

Thanks for the great bug report. A fix has been merged and will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewnoakes drewnoakes

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate query has required GUID drewnoakes/project-system-tools
2 participants
@drewnoakes @vukelich