Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project System: Find in Files should search in project files #35

Closed
6 of 14 tasks
davkean opened this issue May 13, 2016 · 5 comments
Closed
6 of 14 tasks

Project System: Find in Files should search in project files #35

davkean opened this issue May 13, 2016 · 5 comments
Assignees
@davkean
Labels
Area-External Owned by another feature area and not this repo. Likely be closed in lieu of issue against it. Feature-Project-File-Editing Editing the project either while open in Visual Studio, or via other mechanism. Resolution-Duplicate The bug is a duplicate of another bug in this or another repo. Tracking Tracking a bug against another repo or a larger thematic issue tracking a group of work.
Projects
DavKean
Milestone
16.0

Comments

@davkean
Copy link
Member

davkean commented May 13, 2016 •
edited

If you do a Find in Files with a loaded project, VS doesn't search in the project file.

A couple of things to make sure:

Find In Solution works
Open from search results works.

Current State:

With this in-progess PR: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/124985 (Microsofties-only sorry), the following works:

What works:

If project file is closed:

  • Find in Files/Find All set to Project or Solution

If project file is open but not active:

  • Find in Files/Find All set to Project or Solution
  • Find set to Project or Solution

If project file is open and active:

  • Find set to Solution
  • Find in Files/Find All set to Solution
  • Incremental Find

What doesn't work:

If project file is open and active (cause: issue 1):

  • Find set to Project
  • Find in Files/Find All set to Project (returns "No files were found to look in")

If project file is closed (cause: issue 2):

  • Find set to Project or Solution

If AppDesigner is open (cause: issue 3)

  • Find set to Project or Solution

Other:

Issues that need to be solved:

  • 1. If the project file is open and active, Monitor Service thinks Solution is the active hierarchy and not the project.
  • 2. FindOrOpenFile (FindUtil.cpp) is blocking opening the project file because RDT is returning RDT_ProjSlnDocument. Even if it does return, it asks ShellOpenDocumentService to OpenDocumentViaProject via LOGVIEWID_TextView.
  • 3. If AppDesigner is open, ShellOpenDocumentService wants to activate it with a different logical view IVsMultiViewDocumentView.ActivateLogicalView
@davkean davkean added Area-Project System Feature Request Request for a new feature, or new scenario to be handled. labels May 13, 2016
@davkean davkean mentioned this issue May 13, 2016
Closed
@srivatsn srivatsn modified the milestone: Unknown May 24, 2016
@davkean davkean added the Feature-Project-File-Editing Editing the project either while open in Visual Studio, or via other mechanism. label Jun 15, 2016
This was referenced Jan 23, 2017
Closed
Closed
@davkean davkean modified the milestones: 1.1, Unknown Jan 25, 2017
@srivatsn srivatsn modified the milestones: 15.3, 16.0 Mar 1, 2017
@davkean davkean assigned tannergooding and unassigned 333fred Mar 22, 2017
@sharwell
Copy link
Member

sharwell commented Aug 1, 2017

👍 Just hit this today

@davkean davkean mentioned this issue Feb 15, 2018
Closed
@davkean
Copy link
Member Author

davkean commented Apr 19, 2018 •
edited

Being tracked by: https://devdiv.visualstudio.com/DevDiv/Managed%20Project%20System/_workitems/edit/603148.

@davkean davkean added Tracking Tracking a bug against another repo or a larger thematic issue tracking a group of work. Area-External Owned by another feature area and not this repo. Likely be closed in lieu of issue against it. and removed Feature Request Request for a new feature, or new scenario to be handled. labels Apr 19, 2018
@davkean
Copy link
Member Author

davkean commented May 28, 2018

Microsofties, these two PRs are fixing this: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/124985?_a=overview and https://devdiv.visualstudio.com/DevDiv/Default/_git/CPS/pullrequest/124980?_a=overview.

@davkean davkean self-assigned this May 28, 2018
@davkean davkean modified the milestones: 16.0, 15.8 May 28, 2018
@davkean davkean added this to To do in DavKean via automation May 28, 2018
@davkean davkean moved this from To do to In progress in DavKean May 28, 2018
@davkean davkean modified the milestones: 15.8, 15.9, 16.0 Jun 28, 2018
@davkean davkean mentioned this issue Sep 7, 2018
Closed
@gulbanana
Copy link

Definitely running into this recently. The more stuff we put in project files, the more need there is to search them.

@davkean
Copy link
Member Author

davkean commented Oct 1, 2018

Duping this against #4061 which represents the uber change here.

@davkean davkean closed this as completed Oct 1, 2018
DavKean automation moved this from In progress to Done Oct 1, 2018
@davkean davkean added the Resolution-Duplicate The bug is a duplicate of another bug in this or another repo. label Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davkean davkean

Labels
Area-External Owned by another feature area and not this repo. Likely be closed in lieu of issue against it. Feature-Project-File-Editing Editing the project either while open in Visual Studio, or via other mechanism. Resolution-Duplicate The bug is a duplicate of another bug in this or another repo. Tracking Tracking a bug against another repo or a larger thematic issue tracking a group of work.
Projects
No open projects
DavKean
  
Done
Milestone
16.0
Development

No branches or pull requests
6 participants
@srivatsn @davkean @sharwell @gulbanana @333fred @tannergooding