Finish "project file editing" experience

[davkean]

This is a tracking issue for finishing the project file editing:

Current State:

Find

If project file is closed:

• Find in Files/Find All set to Project or Solution (Don't block Find from finding content in "searchable" hierarchies #4065)
• Find set to Project or Solution (Don't block Find from finding content in "searchable" hierarchies #4065 & Stop passing RDT_ProjSlnDocument to RDT #4066)

If project file is open but not active:

• Find in Files/Find All set to Project or Solution (Don't block Find from finding content in "searchable" hierarchies #4065)
• Find set to Project or Solution (Don't block Find from finding content in "searchable" hierarchies #4065)

If project file is open and active:

• Find set to Solution (Don't block Find from finding content in "searchable" hierarchies #4065)
• Find in Files/Find All set to Solution (Don't block Find from finding content in "searchable" hierarchies #4065)
• Incremental Find (Don't block Find from finding content in "searchable" hierarchies #4065)
• Find set to Project (Don't block Find from finding content in "searchable" hierarchies #4065 & Pass project instead of solution as owner to RDT #4067)
• Find in Files/Find All set to Project (returns "No files were found to look in") (Don't block Find from finding content in "searchable" hierarchies #4065 & Pass project instead of solution as owner to RDT #4067)

If AppDesigner is open

• Find set to Project or Solution (Figure out how AppDesigner and Project File editor play with each other to unblock Find when the former is opened #4070)

Open

• Results window (Stop passing RDT_ProjSlnDocument to RDT #4066 & Pass project instead of solution as owner to RDT #4067)
• Error List (Stop passing RDT_ProjSlnDocument to RDT #4066 & Pass project instead of solution as owner to RDT #4067)
• Preview tab (Allow project to be opened in the Preview tab #4068)
• Determine what to do about double-click to open (see OpenProjectEditorOnDefaultActionCommand) - Required, but move to CPS
• File | Open the existing project file should open in text edit mode

Commands

• Project commands are disabled/hidden when the project file editing is disabled (Pass project instead of solution as owner to RDT #4067)
• Create double click handler in CPS for provisional tab support (Allow project to be opened in the Preview tab #4068)

Cleanup

• Remove VerifyOpenProjectFileCapability usage inside shell & dialog (Remove VerifyOpenProjectFileCapability usage inside shell & dialog #4071)
• Remove double click handler from Project System (Remove OpenProjectEditorOnDefaultActionCommand #4134)

Diff

• Cannot edit project file in diff mode (https://developercommunity.visualstudio.com/content/problem/238045/editing-a-csproj-file-through-the-integrated-diffi.html) (Show our project file editor in the right hand side of diff view #4215)

[huoyaoyuan]

Do you have plan for providing IntelliSense on project files?
When customizing my projects, I often need MSBuild reference to check exact spelling/meaning/value rule for properties. I also need reference when reading (not heavily) customized ones.
Currently, a vsix by Microsoft only provides quick information for nuget package reference.
This is not a trival work, so I want to know your choise on it.

[Pilchie]

This is something that's on our backlog, but right now we're focusing on:

1. Performance and scale issues.
2. Reliability issues in NuGet Restore, dependencies node, etc,
3. Support for designers in order to support .NET Core 3.

So it's something we plan to do, but it will likely be a while before we have anything much to show for it.

[davkean]

@huoyaoyuan We do provide some IntelliSense:

Are you saying that you get none? If so, you might be running into dotnet/msbuild#2787.

[huoyaoyuan]

Yes, I get none, even with xmlns added. And my VS is not in English too.

[davkean]

@huoyaoyuan Can you add information to dotnet/msbuild#2787 about the particulars of your OS language & VS language?

[davidwengier]

Going to close this off as the work has been done, and PRs merged.

There is still #4215 outstanding however that is an existing issue, and #4222 still needs to be fixed, but they can be tracked individually.

[drewnoakes]

See also #4325.

[cjbush]

Is there a way to disable double-clicking to edit for csproj files so that it can default to the regular behavior of expanding the node in Solution Explorer?

[davidwengier]

It's coming with #4493

[cjbush]

Thanks! I missed that one.