Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NuGetTargetMoniker instead of TFM if its exists #4859

Merged
merged 1 commit into from May 23, 2019

Conversation

davkean
Copy link
Member

@davkean davkean commented May 23, 2019

Fixes: #4854.

Note: This has localization impact that I believe is okay; if we do not ship localized values - then the user will continue to get the old string.

@davkean davkean requested a review from a team as a code owner May 23, 2019 02:13
@davkean davkean changed the base branch from master to dev16.1.x May 23, 2019 02:13
@davkean davkean merged commit 7c3e3c9 into dotnet:dev16.1.x May 23, 2019
@davkean davkean deleted the UWP branch May 23, 2019 04:53
@tmeschter
Copy link
Contributor

Non-english users will continue to see the older (but still localized) messages, yes.

@jamesmontemagno
Copy link
Member

Is this in 16.1.1 or future?

@davkean
Copy link
Member Author

davkean commented May 26, 2019

16.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants