Add support for delegated completion item resolutions. #6502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a`DelegatedCompletionItemResolver` that understands how to resolve items producted from the `DelegatedCompletionListProvider`. - Added a new `DelegatedCompletionResolutionContext` that's cached along side the delegated completion lists. This is what's used by the resolve to properly delegated item resolutions. - Added tests for new delegated completion item resolution. ### Before  ### After  Fixes #6449
NTaylorMullen
requested review from
a team,
ryanbrandenburg,
allisonchou,
sharwell and
davidwengier
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DelegatedCompletionItemResolverthat understands how to resolve items producted from theDelegatedCompletionListProvider.DelegatedCompletionResolutionContextthat's cached along side the delegated completion lists. This is what's used by the resolve to properly delegated item resolutions.Before
After
Fixes #6449