Fix runtime preventDefault / stopPropagation runtime InvalidOperationException. #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The Blazor runtime doesn't support adding attributes prior to any sort of content frames being applied. This change ensures that `ComponentAttributes` (how preventDefault / stopPropagation are represented) are handled like other HTML attributes (applied first). - Updated existing tests and their baselines. dotnet/aspnetcore#16611
NTaylorMullen
requested review from
SteveSandersonMS,
rynowak,
ajaybhargavb,
danroth27 and
mkArtakMSFT
|
@Pilchie we want to take this for 3.1-preview2. Can you please approve? Thanks! |
|
I can't approve for Preview 2. Please mail tactics for approval. |
mkArtakMSFT
reviewed
Oct 28, 2019
| @@ -2905,7 +2905,7 @@ public void EventHandler_PreventDefault_StopPropagation_Minimized() | |||
| // Act | |||
| var generated = CompileToCSharp(@" | |||
| @using Microsoft.AspNetCore.Components.Web | |||
| <input @onclick:preventDefault @onclick:stopPropagation />"); | |||
| <button @onclick:preventDefault @onclick:stopPropagation>Click Me</button>"); | |||
There was a problem hiding this comment.
Is the feature not supposed to work for input type=button ?
There was a problem hiding this comment.
It works for input but inputs don't typically have child content ("Click Me") so I changed it to a button
mkArtakMSFT
approved these changes
Oct 28, 2019
pranavkm
approved these changes
Oct 28, 2019
|
Approved for 3.1 Preview 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to use Blazor's
@onclick:preventDefaultor@onclick:stopPropagationresults in runtime invalid operation exception.Customer Impact
Customers will not be able to utilize the
preventDefaultorstopPropagationfeatures (even though VS will tell them they're available) because usage of them breaks their pageRegression
No because these are a new feature. The reason why this was missed is because it involved several moving parts of which required Runtime, Tooling and SDK.
Risk
Low. We're just changing the order of how things are rendered. The rendering pipeline should have been doing this from the get-go. The only reason why it wasn't was because of an oversight.
ComponentAttributes(how preventDefault / stopPropagation are represented) are handled like other HTML attributes (applied first).Addresses dotnet/aspnetcore#16611