Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure generic constraints are emitted in correct order #7965

Merged
merged 2 commits into from Dec 2, 2022
Merged

Ensure generic constraints are emitted in correct order #7965

merged 2 commits into from Dec 2, 2022

Conversation

jjonescz
Copy link
Contributor

@jjonescz jjonescz commented Nov 28, 2022 •
edited

Fixes #7074
Fixes #7935
Fixes #7947

Also avoids emitting superfluous struct constraint when the unmanaged constraint is specified.

@jjonescz jjonescz changed the title Ensure struct/class generic constraints are emitted first Ensure generic constraints are emitted in correct order Nov 28, 2022
@jjonescz jjonescz marked this pull request as ready for review November 28, 2022 16:27
@jjonescz jjonescz requested a review from a team as a code owner November 28, 2022 16:27
@jjonescz jjonescz merged commit 4e9a5b2 into dotnet:main Dec 2, 2022
@jjonescz jjonescz deleted the 7074-constraint-ordering branch December 2, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@chsienki chsienki chsienki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jjonescz @333fred @chsienki