Merge pull request #321 from danielcweber/UseTryMethodsForIxToObservable

AsyncEnumerable.ToObservable: Use Try...-methods on TaskCompletionSources to avoid unexpected exceptions when the iterator is cancelled.
dotnet · Jan 25, 2017 · 072abb2 · 072abb2
2 parents 2f275e1 + f47d85e
commit 072abb2
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/Ix.NET/Source/System.Interactive.Async/ToObservable.cs b/Ix.NET/Source/System.Interactive.Async/ToObservable.cs
@@ -119,7 +119,7 @@ public void OnCompleted()
 
                 if (tcs != null)
                 {
-                    tcs.SetResult(false);
+                    tcs.TrySetResult(false);
                 }
             }
 
@@ -140,7 +140,7 @@ public void OnError(Exception error)
 
                 if (tcs != null)
                 {
-                    tcs.SetException(error);
+                    tcs.TrySetException(error);
                 }
             }
 
@@ -165,7 +165,7 @@ public void OnNext(T value)
 
                 if (tcs != null)
                 {
-                    tcs.SetResult(true);
+                    tcs.TrySetResult(true);
                 }
             }
         }