Reduce number of allocations (closures, delegates) in TaskObservableExtensions.ToTask #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtensions.ToTask.
|
@danielcweber this looks great! ✨ Introducing more of these into the Rx side to reduce allocations seems like a good idea for the next minor release. |
clairernovotny
approved these changes
Nov 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the ToTask-extension a lot in our code and found it rather expensive wrt. object allocations. Looking into the code, I found that by implementing a custom IObserver, creation of closures and delegates can be avoided. I think even without anonymous lambdas, the code is still straghtforward and easy to read.