Populate RepositoryBranch package metadata if available #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only do so if PublishRepositoryUrl=true, meaning you want this information to be public in the first place. See RepositoryBranch in https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets.
|
This seems very reasonable, but I have to admit that my first thought was 'why isn't this in dotnet/sourcebuild?'. I looked in that repo and they don't do anything for RepositoryBranch, so I was surprised. |
baronfel
approved these changes
Nov 16, 2022
kzu
added a commit
to kzu/PolySharp
that referenced
this pull request
Nov 16, 2022
As documented in nuget (https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets) you can provide not only the repo URL, type and commit, but also the branch. But this information is not populated by default by the SourceLink package, neither the ReproducibleBuilds (unless the PR at dotnet/reproducible-builds#27 is merged). So just bring the code in that PR here until that's merged and shipped. Fixes Sergio0694#23
|
Gently pinging @clairernovotny 😉 |
|
Anything stopping this PR from merging? Polysharp also waiting on this ... Sergio0694/PolySharp#24 (comment) |
|
Thanks @kzu, and sorry for this one falling through the cracks. |
|
How does this ship? Is it automatic? Did it ship already? |
|
This still hasn't shipped: https://www.nuget.org/packages/DotNet.ReproducibleBuilds |
|
We've shipped this in 1.2.4 at long last! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only do so if PublishRepositoryUrl=true, meaning you want this information to be public in the first place.
See RepositoryBranch in https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets.