Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't access the gitter chat room #2199

Closed
TKharaishvili opened this issue Mar 12, 2019 · 4 comments
Closed

Can't access the gitter chat room #2199

TKharaishvili opened this issue Mar 12, 2019 · 4 comments

Comments

@TKharaishvili
Copy link
Contributor

I can't access the gitter chat room mentioned in the readme.

The link is taking me to the page displaying this:
image

@mavasani
Copy link
Member

mavasani commented Mar 12, 2019

Not sure if anyone in the roslyn-analyzers team is active on gitter anymore :) Is that correct @jinujoseph?

@TKharaishvili Did you have any specific question we can answer?

@TKharaishvili
Copy link
Contributor Author

TKharaishvili commented Mar 12, 2019

@mavasani
Shouldn't the link be removed from readme in that case?

This question comes from the fixer I was implementing for another issue.
I was analyzing the following linq extension method call in both C# and VB

someList.First()

When getting the corresponding IInvocationExpression the Arguments array contained one element for the C# version and no elements for the VB version. I'm not really sure how big a problem this really is, but it does seem to violate Liskov's substitution principle.

My question is - is accessing the Arguments array the correct way of getting the expression the extension method was invoked on? (The someList part in this case) And if not, what is the correct way?

P.S. Should I open a new issue for this question?

@TKharaishvili
Copy link
Contributor Author

Ok, so I found the answer to my question documented in one of Roslyn issues - dotnet/roslyn#23625

But I'll keep this issue open, 'cause I still think the gitter link should be removed from readme if it's no longer active.

@genlu
Copy link
Member

genlu commented Mar 19, 2019

I have removed the link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants