Skip to content

Commit

Permalink
Remove assembly resolving (#1237)
Browse files Browse the repository at this point in the history
  • Loading branch information
josefpihrt committed Nov 9, 2023
1 parent 324071a commit 963de8d
Show file tree
Hide file tree
Showing 10 changed files with 1 addition and 101 deletions.
1 change: 1 addition & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fix [RCS1234](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1234) ([PR](https://github.com/dotnet/roslynator/pull/1233))
- Fix refactoring [Inline method](https://josefpihrt.github.io/docs/roslynator/refactorings/RR0062) ([PR](https://github.com/dotnet/roslynator/pull/1234))
- [CLI] Fix globbing ([PR](https://github.com/dotnet/roslynator/pull/1238))
- [CLI] Remove assembly resolving ([PR](https://github.com/dotnet/roslynator/pull/1237))

## [4.6.1] - 2023-10-23

Expand Down
85 changes: 0 additions & 85 deletions src/CommandLine/AssemblyResolver.cs

This file was deleted.

2 changes: 0 additions & 2 deletions src/CommandLine/Commands/AnalyzeCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ public AnalyzeCommand(AnalyzeCommandLineOptions options, DiagnosticSeverity seve

public override async Task<AnalyzeCommandResult> ExecuteAsync(ProjectOrSolution projectOrSolution, CancellationToken cancellationToken = default)
{
AssemblyResolver.Register();

var codeAnalyzerOptions = new CodeAnalyzerOptions(
fileSystemFilter: FileSystemFilter,
ignoreAnalyzerReferences: Options.IgnoreAnalyzerReferences,
Expand Down
2 changes: 0 additions & 2 deletions src/CommandLine/Commands/FindSymbolsCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ internal class FindSymbolsCommand : MSBuildWorkspaceCommand<CommandResult>

public override async Task<CommandResult> ExecuteAsync(ProjectOrSolution projectOrSolution, CancellationToken cancellationToken = default)
{
AssemblyResolver.Register();

HashSet<string> ignoredSymbolIds = (Options.IgnoredSymbolIds.Any())
? new HashSet<string>(Options.IgnoredSymbolIds)
: null;
Expand Down
2 changes: 0 additions & 2 deletions src/CommandLine/Commands/FixCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ internal class FixCommand : MSBuildWorkspaceCommand<FixCommandResult>

public override async Task<FixCommandResult> ExecuteAsync(ProjectOrSolution projectOrSolution, CancellationToken cancellationToken = default)
{
AssemblyResolver.Register();

var codeFixerOptions = new CodeFixerOptions(
fileSystemFilter: FileSystemFilter,
severityLevel: SeverityLevel,
Expand Down
2 changes: 0 additions & 2 deletions src/CommandLine/Commands/GenerateDocCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,6 @@ internal class GenerateDocCommand : MSBuildWorkspaceCommand<CommandResult>

public override async Task<CommandResult> ExecuteAsync(ProjectOrSolution projectOrSolution, CancellationToken cancellationToken = default)
{
AssemblyResolver.Register();

var documentationOptions = new DocumentationOptions()
{
RootFileHeading = Options.Heading,
Expand Down
2 changes: 0 additions & 2 deletions src/CommandLine/Commands/GenerateDocRootCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ internal class GenerateDocRootCommand : MSBuildWorkspaceCommand<CommandResult>

public override async Task<CommandResult> ExecuteAsync(ProjectOrSolution projectOrSolution, CancellationToken cancellationToken = default)
{
AssemblyResolver.Register();

var documentationOptions = new DocumentationOptions()
{
RootFileHeading = Options.Heading,
Expand Down
2 changes: 0 additions & 2 deletions src/CommandLine/Commands/ListSymbolsCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ internal class ListSymbolsCommand : MSBuildWorkspaceCommand<CommandResult>

public override async Task<CommandResult> ExecuteAsync(ProjectOrSolution projectOrSolution, CancellationToken cancellationToken = default)
{
AssemblyResolver.Register();

var format = new DefinitionListFormat(
layout: Layout,
parts: SymbolDefinitionPartFilter.All & ~IgnoredParts,
Expand Down
2 changes: 0 additions & 2 deletions src/CommandLine/Commands/RenameSymbolCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ internal class RenameSymbolCommand : MSBuildWorkspaceCommand<RenameSymbolCommand

public override async Task<RenameSymbolCommandResult> ExecuteAsync(ProjectOrSolution projectOrSolution, CancellationToken cancellationToken = default)
{
AssemblyResolver.Register();

SymbolRenameState renamer = null;

if (projectOrSolution.IsProject)
Expand Down
2 changes: 0 additions & 2 deletions src/CommandLine/Commands/SpellcheckCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ internal class SpellcheckCommand : MSBuildWorkspaceCommand<SpellcheckCommandResu

public override async Task<SpellcheckCommandResult> ExecuteAsync(ProjectOrSolution projectOrSolution, CancellationToken cancellationToken = default)
{
AssemblyResolver.Register();

VisibilityFilter visibilityFilter = Visibility switch
{
Visibility.Public => VisibilityFilter.All,
Expand Down

0 comments on commit 963de8d

Please sign in to comment.