Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port fixtures from golang tar #264

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Port fixtures from golang tar #264

merged 2 commits into from
Aug 22, 2022

Conversation

danmoseley
Copy link
Member

@danmoseley danmoseley commented Aug 22, 2022

@danmoseley
Copy link
Member Author

@carlossanlop @am11

BTW, I also posted a note asking for clarification about the license of the libarchive test files to be totally sure it's OK to copy them. If it's OK then I'll add those also.

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for adding, @danmoseley !

@am11
Copy link
Member

am11 commented Aug 22, 2022

Thanks. I think we can add libarchive assets as well; with their license in the TPN file. If we get a reply suggesting some other approach, we can then reiterate.

@danmoseley danmoseley merged commit 1b84ca6 into main Aug 22, 2022
@danmoseley danmoseley deleted the go.tar.files branch August 22, 2022 04:36
@danmoseley
Copy link
Member Author

Thanks. I think we can add libarchive assets as well; with their license in the TPN file. If we get a reply suggesting some other approach, we can then reiterate.

I will wait on clarity from libarchive/libarchive#1767

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants