Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Refactor switch statements in process_bb to reduce redundancy #101412

Open
kotlarmilos opened this issue Apr 23, 2024 · 3 comments
Open

[mono] Refactor switch statements in process_bb to reduce redundancy #101412

kotlarmilos opened this issue Apr 23, 2024 · 3 comments
Labels
area-Codegen-meta-mono good first issue Issue should be easy to implement, good for first-time contributors
Milestone

Comments

@kotlarmilos
Copy link
Member

Description

The process_bb function in mini-llvm.c contains about 80 switch statements within switch (ins->opcode) {. The goal is to reduce code redundancy by introducing helper functions. To achieve this, the first step is to identify patterns and common operations within the switch cases. Each pattern should be encapsulated into a helper function.

@kotlarmilos kotlarmilos added good first issue Issue should be easy to implement, good for first-time contributors area-Codegen-meta-mono labels Apr 23, 2024
@kotlarmilos kotlarmilos added this to the Future milestone Apr 23, 2024
Copy link
Contributor

Tagging subscribers to this area: @steveisok, @lambdageek
See info in area-owners.md if you want to be subscribed.

@kapilepatel
Copy link

I someone working on this? I would like to co-work.

@kotlarmilos
Copy link
Member Author

Thanks, I believe no one is working on this at the moment. If you plan to propose changes, I suggest outlining your general approach here first to get feedback before submitting a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Codegen-meta-mono good first issue Issue should be easy to implement, good for first-time contributors
Projects
None yet
Development

No branches or pull requests

2 participants