Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RyuJIT: Add side effect flag checking to LIR::Range::CheckLIR() #10249

Open
erozenfeld opened this issue Apr 26, 2018 · 0 comments
Open

RyuJIT: Add side effect flag checking to LIR::Range::CheckLIR() #10249

erozenfeld opened this issue Apr 26, 2018 · 0 comments
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions JitUntriaged CLR JIT issues needing additional triage
Milestone
Future

Comments

@erozenfeld
Copy link
Member

We check for correctness of side effect flags in fgDebugCheckFlags. We should do that for LIR as well in LIR::Range::CheckLIR().

There is a fundamental difference between side-effects in HIR and LIR in that the flags on a node do not need to be a summary of that node's side effects along with those of its operands: instead, the flags for a node should reflect only that node's side effects.

category:correctness
theme:ir
skill-level:intermediate
cost:medium
@erozenfeld erozenfeld self-assigned this Apr 26, 2018
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
This was referenced Jul 23, 2020
Closed
Merged
@erozenfeld erozenfeld removed their assignment Oct 12, 2020
@BruceForstall BruceForstall added the JitUntriaged CLR JIT issues needing additional triage label Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions JitUntriaged CLR JIT issues needing additional triage
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@msftgits @erozenfeld @BruceForstall