[release/9.0-preview5] Update implicit versions for 6,7,8 #102607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewing
added
Servicing-approved
|
The downlevel workload tests will fail for this since these versions don't exist in public yet. We should probably disable them in the preview/release branches. cc @maraf |
akoeplinger
approved these changes
May 23, 2024
|
@lewing are these failures the ones you expected? Is this OK to merge? |
|
yeah these failures are expected for now, @maraf is working on some logic to avoid them in the future |
|
So I can merge this? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the p5 versions for runtime based on the discussions with the SDK team.